[PATCH] D115030: [mlir][OpenMP] omp.sections and omp.section lowering to LLVM IR

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan accepted this revision.
kiranchandramohan added a comment.

LGTM. I had a look and also compared the behaviour with the clang compiler (without IR builder) and it matches.

Since the change in the OpenMP IRBuilder is minor and to make progress I am approving this although @ftynse specifically asked for a review from @Meinersbur or @jdoerfert. @shraiysh if there are post-commit reviews, please address them.



================
Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:591-592
+  // No sections within omp.sections operation - skip generation
+  if (sectionCBs.size() == 0)
+    return success();
+
----------------
Nit: Can you expand the comment to say that this situation is only possible if there is only a terminator operation inside the sections operation? May be also assert for that situation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115030/new/

https://reviews.llvm.org/D115030