[PATCH] D87202: Add new choices dot-cfg and dot-cfg-quiet to print-changed which creates a website of DOT files showing colourized changes as the IR is changed by passes in the new pass manager pipeline.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

This commit broke the non-HTML output, causing https://github.com/llvm/llvm-project/issues/52610



================
Comment at: llvm/include/llvm/Support/GraphWriter.h:259
     if (DTraits.hasEdgeDestLabels()) {
       O << "|{";
 
----------------
Surely you don't want this for HTML?


================
Comment at: llvm/include/llvm/Support/GraphWriter.h:268-271
+      if (RenderUsingHTML)
+        O << "<td colspan=\"1\">... truncated</td>";
+      else if (i != e)
+        O << "|<d64>truncated...}";
----------------
I believe this whole chunk of code is meant to be this


================
Comment at: llvm/include/llvm/Support/GraphWriter.h:269
+      if (RenderUsingHTML)
+        O << "<td colspan=\"1\">... truncated</td>";
+      else if (i != e)
----------------
This makes no sense. It's not truncated if `i != e`?


================
Comment at: llvm/include/llvm/Support/GraphWriter.h:271
+      else if (i != e)
+        O << "|<d64>truncated...}";
     }
----------------
The `}` was unconditional before, now it's conditional so you get mismatched `}`s and graphviz errors out unless you have more than 64 edge dest labels


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87202/new/

https://reviews.llvm.org/D87202