[PATCH] D115565: [DebugInfo][dsymutil] Keep locations for function-local globals

[Ellis Hoag via Phabricator via llvm-commits]

ellis created this revision.
Herald added a subscriber: hiraditya.
Herald added a reviewer: JDevlieghere.
ellis updated this revision to Diff 393640.
ellis added a comment.
ellis updated this revision to Diff 393643.
ellis updated this revision to Diff 393650.
ellis updated this revision to Diff 393654.
ellis edited the summary of this revision.
ellis added a reviewer: dblaikie.
ellis added a project: debug-info.
ellis added reviewers: clayborg, kyulee.
ellis published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fix test


ellis added a comment.

Change comment.


ellis added a comment.

Add entry to debug map.


ellis added a comment.

Add comments to test.


In debug info, we expect variables to have location info if they are used and we don't want location info for functions that are not used. However, if an unused function is inlined, we could have the scenario where a function is not in the final binary but its static variable is in the final binary. Ensure that variables in the final binary have location debug info even if their scope was inlined.

Also add `--implicit-check-not` to a test for clarity.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115565

Files:
  llvm/lib/DWARFLinker/DWARFLinker.cpp
  llvm/test/tools/dsymutil/Inputs/inlined-static-variable/4.o
  llvm/test/tools/dsymutil/X86/dead-stripped.cpp
  llvm/test/tools/dsymutil/X86/dummy-debug-map.map
  llvm/test/tools/dsymutil/X86/inlined-static-variable.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115565.393654.patch
Type: text/x-patch
Size: 5730 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211211/d178844a/attachment.bin>