[PATCH] D113610: Only set LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib

[Ben Langmuir via Phabricator via llvm-commits]

benlangmuir added a comment.

Since the new approach is no longer "opt-in", I tested:

- Default build (static, LLVMInitialize* is external)
- `-DCMAKE_CXX_VISIBILITY_PRESET=hidden` (static, LLVMInitialize* is hidden -- this is the new thing)
- `-DBUILD_SHARED_LIBS=YES` (dynamic, LLVMInitialize* is external due to not overriding visibility)
- `-LLVM_LINK_LLVM_DYLIB=YES` (dynamic, LLVMInitialize* is external due to LLVM_EXTERNAL_VISIBILITY)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113610/new/

https://reviews.llvm.org/D113610