[PATCH] D115554: [gn build] Remove unnecessary lld dependency on DebugInfo/Symbolize dependency.

[Noah Shutty via Phabricator via llvm-commits]

noajshu updated this revision to Diff 393603.
noajshu added a comment.

Replace include of Symbolize.h with DIContext.h in lld/COFF/SymbolTable.cpp. LLD just needs llvm/DebugInfo/DIContext.h which it currently gets through
Symbolize.h -> SymbolizableModule.h -> DIContext.h.
This needlessly pulls in extra headers (and perhaps led to the gn dep line fixed in this diff, although I'm not familiar with how the gn build is maintained.).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115554/new/

https://reviews.llvm.org/D115554

Files:
  lld/COFF/SymbolTable.cpp
  llvm/utils/gn/secondary/lld/COFF/BUILD.gn


Index: llvm/utils/gn/secondary/lld/COFF/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/lld/COFF/BUILD.gn
+++ llvm/utils/gn/secondary/lld/COFF/BUILD.gn
@@ -15,7 +15,6 @@
     "//llvm/lib/DebugInfo/CodeView",
     "//llvm/lib/DebugInfo/MSF",
     "//llvm/lib/DebugInfo/PDB",
-    "//llvm/lib/DebugInfo/Symbolize",
     "//llvm/lib/IR",
     "//llvm/lib/LTO",
     "//llvm/lib/MC",
Index: lld/COFF/SymbolTable.cpp
===================================================================
--- lld/COFF/SymbolTable.cpp
+++ lld/COFF/SymbolTable.cpp
@@ -16,7 +16,7 @@
 #include "lld/Common/ErrorHandler.h"
 #include "lld/Common/Memory.h"
 #include "lld/Common/Timer.h"
-#include "llvm/DebugInfo/Symbolize/Symbolize.h"
+#include "llvm/DebugInfo/DIContext.h"
 #include "llvm/IR/LLVMContext.h"
 #include "llvm/LTO/LTO.h"
 #include "llvm/Object/WindowsMachineFlag.h"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115554.393603.patch
Type: text/x-patch
Size: 908 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211210/5626410c/attachment.bin>