[PATCH] D113717: [Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added a comment.

In D113717#3186152 <https://reviews.llvm.org/D113717#3186152>, @dblaikie wrote:

> @noajshu Could you look into if/how lld uses the symbolizer and if there are use cases where it would have an positive effect on the user experience (improved diagnostic quality, etc) to lookup debug info on the symbol server? If there are no such cases, maybe having a separate entry point into the symbolizing library that statically does not use debuginfod would be good. The library dependency would still be there, but if a caller only uses the non-debuginfod entry point, nothing from the debuginfod library would be pulled in at link time.

Good idea, thanks for the recommendation!
I've taken a look and lld. There is no usage of the definitions in Symbolize.cpp. This is unsurprising as removing the lib dep in D115554 <https://reviews.llvm.org/D115554> did not break the gn build.
There is one file, `lld/COFF/SymbolTable.cpp` that includes "llvm/DebugInfo/Symbolize.h". This is a red herring, lld not use any of the `Symbolize.h` declarations. It actually just needs `llvm/DebugInfo/DIContext.h` which is included as
`Symbolize.h -> SymbolizableModule.h -> DIContext.h`.
So probably that line should be replaced with `#include "llvm/DebugInfo/DIContext.h"`. I'm happy to add this to D115554 <https://reviews.llvm.org/D115554>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113717/new/

https://reviews.llvm.org/D113717