[PATCH] D115555: [RISCV] Use AdjustInstrPostInstrSelection to insert a FRM dependency for scalar FP instructions with dynamic rounding mode.

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 10 15:07:28 PST 2021


jrtc27 added a comment.

As it stands the implementation is a bit assuming, relying on it only ever being called for floating point instructions (or those that don't have a funct3), but there are other uses, so should also be checking getOperandType is OpTypes::frmarg? Could even ditch the name lookup entirely and just iterate over the use operands, don't know what's better.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.h:23
 
+#define GET_INSTRINFO_OPERAND_ENUM
+#include "RISCVGenInstrInfo.inc"
----------------
Combine?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115555/new/

https://reviews.llvm.org/D115555



More information about the llvm-commits mailing list