[PATCH] D115551: [AMDGPU] Do not reserve any VGPR for SGPR spills

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 10 15:02:42 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:1321-1323
-  const bool WillHaveFP =
-      FrameInfo.hasCalls() && (HaveAnyCSRVGPR || MFI->VGPRReservedForSGPRSpill);
 
----------------
kerbowa wrote:
> arsenm wrote:
> > I don't see why you're changing this, this is still an issue?
> With the change, we are being more conservative.
But why, I don't see the connection to eliminating the reserved register


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115551/new/

https://reviews.llvm.org/D115551



More information about the llvm-commits mailing list