[PATCH] D115556: [lld-macho][nfc] Simplify LC_DATA_IN_CODE generation

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 10 14:57:29 PST 2021


int3 created this revision.
int3 added a reviewer: lld-macho.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

1. After D113241 <https://reviews.llvm.org/D113241>, we have the section address easily accessible and no longer need to iterate across the LC_SEGMENT commands to emit LC_DATA_IN_CODE.

2. There's no need to store a pointer to the data in code entries during the parse step; we can just look it up as part of the output step.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115556

Files:
  lld/MachO/InputFiles.cpp
  lld/MachO/InputFiles.h
  lld/MachO/SyntheticSections.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115556.393602.patch
Type: text/x-patch
Size: 4506 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211210/c20d2709/attachment.bin>


More information about the llvm-commits mailing list