[PATCH] D115465: [NFC][MLGO] Factor ModelUnderTrainingRunner for reuse
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 10 11:16:10 PST 2021
mtrofin marked an inline comment as done.
mtrofin added inline comments.
================
Comment at: llvm/lib/Analysis/ModelUnderTrainingRunner.cpp:42
+ }
+ return LastEvaluationResult->getTensorValue<int64_t>(0);
+}
----------------
yundiqian wrote:
> this is inline & regalloc specific, up to you to decide whether to fix it this time (when checking in regalloc code) or next time when we have different output types
good catch! We can just return the untyped value, we have an API for that. Fixing now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115465/new/
https://reviews.llvm.org/D115465
More information about the llvm-commits
mailing list