[PATCH] D115528: Revert "X86InstrInfo: Support immediates that are +1/-1 different in optimizeCompareInstr"

Bogdan Graur via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 10 08:13:19 PST 2021


bgraur created this revision.
Herald added subscribers: pengfei, hiraditya.
bgraur requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This reverts commit 847a6807332b13f43704327c2d30103ec0347c77 <https://reviews.llvm.org/rG847a6807332b13f43704327c2d30103ec0347c77>.

The reverted revision was causing miscompiles that manifest on AMD
machines.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115528

Files:
  llvm/lib/Target/X86/X86InstrInfo.cpp
  llvm/lib/Target/X86/X86InstrInfo.h
  llvm/test/CodeGen/X86/optimize-compare.mir
  llvm/test/CodeGen/X86/peep-test-5.ll
  llvm/test/CodeGen/X86/use-cr-result-of-dom-icmp-st.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115528.393498.patch
Type: text/x-patch
Size: 22167 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211210/7e001093/attachment.bin>


More information about the llvm-commits mailing list