[PATCH] D115488: [amdgpu] Increase alignment of all LDS variables

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

I thought overaligning these would be a loss in general when it was proposed (hence the flag) but haven't done the benchmarking. Kind of taking it on faith that someone else has since the feature was implemented. epsdb passed fwiw.

To be more precise, I'm not convinced this makes much real world difference as most variables are naturally aligned anyway but it looks like a mistake that we only change the subset of LDS variables that are already slow to access and allocated in many places.

Also totally happy with deleting this feature or defaulting it to off. The point of this exercise is to get it out of the 'lowering' LDS pass and into a to be written 'optimisation' LDS pass, where this is the (minor?) semantic half of that change and moving it to a separate pass would then be non-functional.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115488/new/

https://reviews.llvm.org/D115488