[PATCH] D115333: [flang][codegen] Add a conversion for `fir.coordinate_of` - part 2

[Valentin Clement via Phabricator via llvm-commits]

clementval added inline comments.


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2981
+  bool validCoordinate(mlir::Type type, mlir::ValueRange coors) const {
+    const size_t sz = coors.size();
+    std::remove_const_t<decltype(sz)> i = 0;
----------------
we use `std::size_t` in other places. Can you add it here as well and in other places?


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:2982
+    const size_t sz = coors.size();
+    std::remove_const_t<decltype(sz)> i = 0;
+    bool subEle = false;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115333/new/

https://reviews.llvm.org/D115333