[PATCH] D114225: Add JSONScopedPrinter to llvm-readelf

[Jayson Yan via Phabricator via llvm-commits]

Jaysonyan added a comment.

Just as a heads up, Dec 10th is the last day of my internship so unfortunately after that I won't be able to work on this change as actively as before. If there is still feedback to address a member of my team may be able to pick this up from where I left off. And thank you for taking the time to review all of my code changes these past months!



================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-summary-json.test:64-66
+# ARCH-SINGLE-NEXT:    "[[ARFILE]]({{.*}}o)": {
+# ARCH-SINGLE-NEXT:      "FileSummary": {
+# ARCH-SINGLE-NEXT:        "File": "[[ARFILE]]({{.*}}o)",
----------------
jhenderson wrote:
> You should be able to be more precise, rather than skipping a chunk of the name. I think the relevant lit macro is %basename_t or something to that effect. You could pass that into an additional argument e.g. `-DMEMBER`.
I was able to remove the `{{.*}}` by matching the structure of `llvm-readobj/archive.test`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114225/new/

https://reviews.llvm.org/D114225