[PATCH] D112696: CycleInfo: Introduce cycles as a generalization of loops

Fri Dec 10 01:13:07 PST 2021

sameerds added a comment.

In D112696#3181899 <https://reviews.llvm.org/D112696#3181899>, @sameerds wrote:

> In D112696#3177463 <https://reviews.llvm.org/D112696#3177463>, @JDevlieghere wrote:
>
>> I've reverted this in 02940d6d22022dbad45efa0c9a5cc772ba844da4 <https://reviews.llvm.org/rG02940d6d22022dbad45efa0c9a5cc772ba844da4> because it breaks the modules builds:
>>
>> https://green.lab.llvm.org/green/job/clang-stage2-rthinlto/4858/
>> https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39112/
>
> I managed to reproduce the breakage locally with `-DLLVM_ENABLE_MODULES=On`. With my latest revision, I can see that the error specifically mentioning my files has disappeared, but the build does not complete. @JDevlieghere do you have any advice on perfectly reproducing that build locally? Are there other things to be specified on the cmake line?

@JDevlieghere, I am still unable to produce a modules build locally, but spent some effort convincing myself that the latest revision of my patch no longer introduces the original problem. I've submitted my fixed version with that confidence, but will keep an eye on the builds it broke. Do give me a chance to upload a fix before reverting, say within 24 hours of any new breakage.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112696/new/

https://reviews.llvm.org/D112696