[PATCH] D113104: add the xcoff symbol size for the llvm-nm.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/size.test:17
+
+# NM-SIZE:      00000040 00000000 T ._Z5func1i 
+# NM-SIZE:      0000010c 0000000c D _Z5func1i
----------------
There's a trailing space on this line, I think.


================
Comment at: llvm/test/tools/llvm-nm/XCOFF/size.test:17-22
+# NM-SIZE:      0000104 00000004 d _Z5func1i
+# NM-SIZE-NEXT: 0000010c 0000000c D _Z5func1i
+# NM-SIZE-NEXT: 00000100 00000004 d value
+# NM-SIZE-NEXT: 00000118 00000004 D value
+# NM-SIZE-NEXT: 00000108 00000004 d weak_value
+# NM-SIZE-NEXT: 0000011c 00000004 W weak_value
----------------
DiggerLin wrote:
> jhenderson wrote:
> > I think it would be sufficient to only test a couple of symbols that have different sizes. You can leave out the others.
> I will simple the test case.
> It will test the size of label, TC entry, Section Description (both for function and data). 
I'd explicitly highlight why you are specifying the specific symbols then in the test, by expanding the initial comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113104/new/

https://reviews.llvm.org/D113104