[PATCH] D60392: FileCheck [12/12]: Support use of var defined on same line

Fri Dec 10 00:18:22 PST 2021

jhenderson added a comment.

In D60392#3184072 <https://reviews.llvm.org/D60392#3184072>, @jdenny wrote:

> In D60392#3182279 <https://reviews.llvm.org/D60392#3182279>, @thopre wrote:
>
>> Hi Joel,
>
> Hi Thomas.
>
>> I like the suggestion of CHECK-ASSERT or a new syntax. I'll think about it
>
> Thanks for considering that.
>
>> and in the meantime anyone with an opinion on this feel free to chime in.
>
> Yes, it will be good to get other opinions.  @jhenderson?

I think @jdenny has hit the nail on the head with regards to a fairly major problem with this patch. I don't think we want to introduce subtleties in behaviour like has been highlighted. Sorry for not considering this before.

Regarding the CHECK-ASSERT suggestion, do we need it? I was under the impression one of the earlier patches added a syntax like `[[#VAR2, VAR1 + 3:]]` or something to that effect, which achieves the same thing, right? Maybe I'm missing something though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60392/new/

https://reviews.llvm.org/D60392