[PATCH] D115133: [RISCV] Support immediate vtype of VSETVLI/VSETIVLI in asm parser

[LiqinWeng via Phabricator via llvm-commits]

Miss_Grape added inline comments.


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:431
+
+  // if the last operand of the vsetvli/vsetvli instruction is a constant
+  // expression, KindTy is Immedidate
----------------
craig.topper wrote:
> Capitalize 'if'
Done


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:432
+  // if the last operand of the vsetvli/vsetvli instruction is a constant
+  // expression, KindTy is Immedidate
+  bool isVTypeI10() const {
----------------
craig.topper wrote:
> Immedidate -> Immediate
Done


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:434
+  bool isVTypeI10() const {
+    if (Kind == KindTy::Immediate) {
+      return isVTypeImm<10>();
----------------
craig.topper wrote:
> Drop curly braces
Done


================
Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:440
+  bool isVTypeI11() const {
+    if (Kind == KindTy::Immediate) {
+      return isVTypeImm<11>();
----------------
craig.topper wrote:
> Drop curly braces
Done


================
Comment at: llvm/test/MC/RISCV/rvv/vsetvl.s:19
+vsetvli a2, a0, 0xd0
+# CHECK-INST: vsetvli a2, a0, e32,  m1,  ta,  ma
+# CHECK-ENCODING: [0x57,0x76,0x05,0x0d]
----------------
craig.topper wrote:
> Why 2 spaces between each operand?
Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115133/new/

https://reviews.llvm.org/D115133