[PATCH] D115469: [RISCV] Share tablegen classes for F, D, and Zfh. Other simplifications. NFC

Shao-Ce SUN via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 17:51:10 PST 2021


achieveartificialintelligence added a comment.

LGTM. And this patch will improve  D93298 <https://reviews.llvm.org/D93298> a lot. Thanks!



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoD.td:61-72
+def FADD_D : FPALU_rr_frm<0b0000001, "fadd.d", FPR64>,
              Sched<[WriteFALU64, ReadFALU64, ReadFALU64]>;
-def        : FPALUDDynFrmAlias<FADD_D, "fadd.d">;
-def FSUB_D : FPALUD_rr_frm<0b0000101, "fsub.d">,
+def        : FPALUDynFrmAlias<FADD_D, "fadd.d", FPR64>;
+def FSUB_D : FPALU_rr_frm<0b0000101, "fsub.d", FPR64>,
              Sched<[WriteFALU64, ReadFALU64, ReadFALU64]>;
-def        : FPALUDDynFrmAlias<FSUB_D, "fsub.d">;
-def FMUL_D : FPALUD_rr_frm<0b0001001, "fmul.d">,
+def        : FPALUDynFrmAlias<FSUB_D, "fsub.d", FPR64>;
+def FMUL_D : FPALU_rr_frm<0b0001001, "fmul.d", FPR64>,
----------------
How about put Alias together?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115469/new/

https://reviews.llvm.org/D115469



More information about the llvm-commits mailing list