[PATCH] D113717: [Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer.

Thu Dec 9 16:58:05 PST 2021

noajshu added inline comments.

================
Comment at: compiler-rt/lib/sanitizer_common/symbolizer/scripts/global_symbols.txt:75
+getCachedOrDownloadDebuginfoENS_8ArrayRef T
+getDefaultDebuginfodCacheDirectory T
+getDefaultDebuginfodTimeout T
----------------
vitalybuka wrote:
> noajshu wrote:
> > vitalybuka wrote:
> > > we cannot do that
> > > all allowed symbols are essentially glibc or sanitizer itself
> > > but nothing will resolve these symbols
> > > 
> > Sorry, I'm just trying to understand what this does and I saw several commits added symbols to that list in the past.
> > 
> > Can you give me some idea of what the general problem is? Do I need to update the buildbot configuration since I'm linking the symbolizer against a new library (Debuginfod)? Or did the sanitizer detect a bug in my code? 
> I guess bot will fail on later step.
> global_symbols.txt it the list of unresolved symbols in this lib and we expect no llvm stuff there
> sanitized user apps may link this lib and without  need for any llvm stuff
> 
> sorry, that I didn't realized this before, but we just need to include Debuginfod into
> llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
Excellent, thank you so much! I will revert this commit, apply this change, remove my edits to the global_symbols.txt, and then re-push.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113717/new/

https://reviews.llvm.org/D113717