[PATCH] D113613: [ThinLTO][MC] Use conditional assignments for promotion aliases

Sami Tolvanen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 15:23:28 PST 2021


samitolvanen updated this revision to Diff 393301.
samitolvanen added a comment.

Based on more offline feedback from pcc, moved the conditional assignment handling from `MCStreamer` to `MCObjectStreamer`. This allows us to drop the `emittedSymbols` set as `MCAssembler` already keeps track of the symbols. As `MCAsmStreamer` now passes through the `.lto_set_conditional` directives, changed the tests to look at the generated objects instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113613/new/

https://reviews.llvm.org/D113613

Files:
  llvm/include/llvm/MC/MCObjectStreamer.h
  llvm/include/llvm/MC/MCStreamer.h
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCObjectStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCStreamer.cpp
  llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
  llvm/test/MC/ELF/lto-set-conditional.s
  llvm/test/MC/MachO/lto-set-conditional.s
  llvm/test/ThinLTO/X86/devirt2.ll
  llvm/test/Transforms/ThinLTOBitcodeWriter/cfi-icall-static-inline-asm.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113613.393301.patch
Type: text/x-patch
Size: 14911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211209/63bf1ef9/attachment-0001.bin>


More information about the llvm-commits mailing list