[PATCH] D115302: GlobalsModRef should treat functions w/o nosync conservatively.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 14:52:32 PST 2021


tra added a comment.

In D115302#3183986 <https://reviews.llvm.org/D115302#3183986>, @efriedma wrote:

>> Problem: not all intrinsics have been converted to use default attributes, so it will be a performance regression for them.
>
> This could be a problem, yes.  Not sure how much of one it is in practice.



In D115302#3183996 <https://reviews.llvm.org/D115302#3183996>, @jdoerfert wrote:

> We have DefaultIntrinsic for a really long while now. Targets won't change if they don't have too. Let's prioritize correctness and require nosync, tell people on the list to update their def files already.

It might be easier to send the patch and let interested parties review them. I'll do it shortly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115302/new/

https://reviews.llvm.org/D115302



More information about the llvm-commits mailing list