[PATCH] D113610: [cmake] Add option LLVM_ENABLE_VISIBILITY_MACROS

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

In D113610#3183993 <https://reviews.llvm.org/D113610#3183993>, @benlangmuir wrote:

> In D113610#3183924 <https://reviews.llvm.org/D113610#3183924>, @dexonsmith wrote:
>
>> My guess would be that the alternative use case you're proposing is pretty rare, in which case @rnk's suggestion SGTM. Later, if someone comes across it, we can add the flag to override the default (which would still depend on shared vs. static).
>
> @dexonsmith @rnk do you have an opinion on whether we should disable both macros, or only `LLVM_EXTERNAL_VISIBILITY` in that case? I hadn't really thought about it before, but `LLVM_LIBRARY_VISIBILITY` (hidden) might still make sense to keep in the static build since it's marked on symbols that are library-local either way.

Yup, seems reasonable. If/when there's an option, could probably call it `LLVM_ENABLE_EXTERNAL_VISIBILITY`, defaulting to "off" for static / "on" for shared.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113610/new/

https://reviews.llvm.org/D113610