[PATCH] D113717: [Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer.

[Noah Shutty via Phabricator via llvm-commits]

noajshu added inline comments.


================
Comment at: llvm/tools/llvm-symbolizer/CMakeLists.txt:13
   DebugInfoPDB
+  Debuginfod
   Demangle
----------------
vitalybuka wrote:
> noajshu wrote:
> > vitalybuka wrote:
> > > Something with llvm::getCachedOrDownloadDebuginfo(llvm::ArrayRef<unsigned char>) is needed
> > > https://lab.llvm.org/buildbot/#/builders/37/builds/9005
> > Thanks for pointing this out. Do you know if it might be related to the use of
> > ```
> > typedef ArrayRef<uint8_t> BuildIDRef;
> > typedef SmallVector<uint8_t, 10> BuildID;
> > ```
> > ?
> I don't know
I noticed that shortly after I committed this in 02cc8d69, Nico Weber kindly ported the gn build with 0f865dc6. I think this may be what's missing to fix the sanitizer buildbot and I've added the corresponding edit below. Next time I commit I'll watch this bot closely to see if it recurs. Thanks again for pointing out the failure!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113717/new/

https://reviews.llvm.org/D113717