[PATCH] D114548: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 13:13:31 PST 2021


eugenis added a comment.

Sorry for the delayed review.



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:3494
       // Found a gap.
-      TSE.emitCode(InsertI, TFI, /*IsLast = */ false);
+      TSE.emitCode(InsertI, TFI, /*TryMergerSPUpdate = */ false);
       TSE.clear();
----------------
typo: TryMergeSPUpdate


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:609
+    MI.setDesc(TII->get(Op));
+    MI.tieOperands(1, 3);
   } else {
----------------
Is this an unrelated fix? Are we generating broken code because of this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114548/new/

https://reviews.llvm.org/D114548



More information about the llvm-commits mailing list