[PATCH] D115353: Verifier: accept enums as scopes

Thu Dec 9 12:37:01 PST 2021

dblaikie added a comment.

In D115353#3179986 <https://reviews.llvm.org/D115353#3179986>, @ychen wrote:

> Oops, apologies for breaking Rust. I'm no debuginfo expert, just wondering if we could keep this check for C/C++?

Reckon it's worth the special case, though? I don't feel super strongly either way - I guess we already do have the "CurrentSourceLang" there and use it for some fortran special case, so we could test it here too. But I'm not sure how valuable it is?

The original bug/issue should be caught during IR merging instead - and since the goal is to support the case of member functions in enums, it's not like the LLVM codegen can't handle this case (when it's C++ or any other language).

(I assume the verifier check was added originally because members in enums broke LLVM in some way? But that bug has been/is being fixed so Rust keeps working? Or did it never break LLVM but instead just produce "weird" DWARF?)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115353/new/

https://reviews.llvm.org/D115353