[PATCH] D115393: [InstrProf][NFC] Refactor Profile kind into a bitset enum.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish added a comment.

@xur Could you please take a look with a focus on ensuring that this change retains the semantics that you expect? Previously there were different enum values which indicated CS+IR vs IR only. Now the IR bit is set for both cases (to be consistent with the version mask). I believe this was the original intent. The only change I had to make was reorder the print in the text format writer.



================
Comment at: llvm/include/llvm/ProfileData/InstrProfWriter.h:48
 public:
-  InstrProfWriter(bool Sparse = false, bool InstrEntryBBEnabled = false);
   ~InstrProfWriter();
----------------
tejohnson wrote:
> Was the InstrEntryBBEnabled parameter just never used? I didn't see any changes to callsites.
I didn't find any uses in llvm and I don't see it being used in the original commit: https://git.io/JDt8k. There is a chance that it could be used by a downstream user but it's unlikely? I'll wait for @xur to chime in.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115393/new/

https://reviews.llvm.org/D115393