[PATCH] D114712: [libc] Bazel overlay for libc

[Geoffrey Martin-Noble via Phabricator via llvm-commits]

GMNGeoffrey accepted this revision.
GMNGeoffrey added subscribers: mtrofin, dblaikie.
GMNGeoffrey added a comment.
This revision is now accepted and ready to land.

Nice! Thanks for iterating on this. It looks like the Bazel build has been broken since yesterday evening. The error looks unrelated to libc, but would still be good to have a clean build. Maybe wait till @dblaikie or @mtrofin get a chance to fix it or rebase on the last passing commit (https://github.com/llvm/llvm-project/commit/a556ec8861) so we can make sure this is all working properly. I don't see the libc targets showing up in the build logs, but I think that's just because it's a `bazel test` invocation so the final summary just prints tests (even though it does also build the targets specified). Have you double checked that these targets show up in `bazel query @llvm-project//...` as expected (I can check, if you'd like).



================
Comment at: utils/bazel/llvm-project-overlay/libc/BUILD.bazel:36
+
+######################################## Support libraries #########################################
+
----------------
Nit: there's no official line length limit in the style guide, but it is recommended to wrap at 80 (79?) where possible, so I think it makes sense to have the line fills and explicit wraps be that wide. https://docs.bazel.build/versions/main/skylark/bzl-style.html#line-length


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114712/new/

https://reviews.llvm.org/D114712