[PATCH] D115024: [ifs] Patch llvm-ifs to allow output multiple types of stub file at the same time

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 10:19:21 PST 2021


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/tools/llvm-ifs/llvm-ifs.cpp:496
+    // Check if output path for individual format.
+    if (OutputELFFilePath.getNumOccurrences() == 1) {
+      Error TargetError = validateIFSTarget(Stub, true);
----------------
Does this mean that if someone passes `--output-elf=foo --output-elf=bar` we won't take this branch because `OutputELFFilePath.getNumOccurrences() == 2`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115024/new/

https://reviews.llvm.org/D115024



More information about the llvm-commits mailing list