[PATCH] D115242: [ARM] Handle splats of constants for MVE qr instruction

[Sam Tebbs via Phabricator via llvm-commits]

samtebbs added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:7720
+// operand Op.
+static bool IsQRMVEInstruction(const SDNode *N, const SDNode *Op) {
+  switch (N->getOpcode()) {
----------------
Can this info be put in tablegen somehow? We might well add support for a qr instruction and forget to add it here.


================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.cpp:7785
+               [BVN](const SDNode *U) { return IsQRMVEInstruction(U, BVN); })) {
+      EVT DupVT = SplatBitSize == 32   ? MVT::v4i32
+                  : SplatBitSize == 16 ? MVT::v8i16
----------------
I know that a 64 bit SplatBitSize shouldn't be legal at this point, but it may be worth adding an assertion to make sure it isn't 64, just for future proofing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115242/new/

https://reviews.llvm.org/D115242