[PATCH] D115402: AMDGPU: Add second emergency slot for SGPR to vmem for large frames

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 07:42:23 PST 2021


arsenm added a comment.

In D115402#3182222 <https://reviews.llvm.org/D115402#3182222>, @critson wrote:

> This seems fine to me, but I am slightly confused the description mentions Wave32, but the test is for GFX9 Wave64.
> I can clearly see the test exercises the new code, but do we need to also test/implement the Wave32 part?

The description mentions an alternative strategy which won't always work for wave32, so why it's done this way


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115402/new/

https://reviews.llvm.org/D115402



More information about the llvm-commits mailing list