[PATCH] D114225: Add JSONScopedPrinter to llvm-readelf

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-summary-json.test:3-4
+
+# RUN: rm -f %t.o
+# RUN: yaml2obj %s -o %t.o
+
----------------
No need to `rm` an object file. That's only necessary for archive files (yaml2obj overwrites the existing file, whereas llvm-ar appends to it).


================
Comment at: llvm/test/tools/llvm-readobj/ELF/file-summary-json.test:64-66
+# ARCH-SINGLE-NEXT:    "[[ARFILE]]({{.*}}o)": {
+# ARCH-SINGLE-NEXT:      "FileSummary": {
+# ARCH-SINGLE-NEXT:        "File": "[[ARFILE]]({{.*}}o)",
----------------
You should be able to be more precise, rather than skipping a chunk of the name. I think the relevant lit macro is %basename_t or something to that effect. You could pass that into an additional argument e.g. `-DMEMBER`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114225/new/

https://reviews.llvm.org/D114225