[PATCH] D115362: Compute estimated trip counts for multiple exit loops

Thu Dec 9 06:35:40 PST 2021

anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.

LGTM.

In D115362#3180931 <https://reviews.llvm.org/D115362#3180931>, @reames wrote:

> In D115362#3180798 <https://reviews.llvm.org/D115362#3180798>, @anna wrote:
>
>> Nice find! This is obviously a good thing to do for unrolling. Any ideas why there's no vectorization test cases to update since we do support multi-exit vectorization?
>
> Well, purely because I didn't write one.  The unrolling test change didn't exist either before I wrote the one showing a diff this morning.  Note that even that one requires a non-default flag value to show up.
>
> I don't think the change in vectorization is likely to be interesting, and crafting a test will be tedious.  Do you want me to bother?

That's fine. Was just curious on how this would show up with vectorization. Given it is tedious and non-obvious, the patch as-is looks good.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115362/new/

https://reviews.llvm.org/D115362