[PATCH] D115432: [LV][ARM] Improve reduction costmodel for mismatching extension types.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 9 02:56:30 PST 2021


sdesmalen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:7086
+      Type *Op1Ty = Op1->getOperand(0)->getType();
+      Type *LargestOpTy =
+          Op0Ty->getIntegerBitWidth() < Op1Ty->getIntegerBitWidth() ? Op1Ty
----------------
Is there any rationale for using the largest instead of the smallest type here? And would changing it to the smallest change the result of the test?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115432/new/

https://reviews.llvm.org/D115432



More information about the llvm-commits mailing list