[PATCH] D114506: [AArch64][SVE]Support for SVE instrinsic in AArch64TargetTransformInfo

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

Sorry I missed that you updated the patch.



================
Comment at: llvm/test/Transforms/LoopStrengthReduce/AArch64/sve-load-store-intrinsics.ll:7
+; check that after loop-reduce, sve.load reuses the original induction variable.
+
+; CHECK: %lsr.iv = phi i64 [ %lsr.iv.next, %for.body ], [ 0, %for.body.lr.ph ]
----------------
nit: please also add:

  CHECK-LABEL: @sve-load-store-intrinsics


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/AArch64/sve-load-store-intrinsics.ll:36
+  %arrayidx1 = getelementptr inbounds i32, i32* %c, i64 %i.06
+  %7 = tail call <vscale x 4 x i32> @llvm.aarch64.sve.ld1.nxv4i32(<vscale x 4 x i1> %5, i32* %arrayidx1)
+  %8 = tail call <vscale x 4 x i32> @llvm.aarch64.sve.add.nxv4i32(<vscale x 4 x i1> %5, <vscale x 4 x i32> %6, <vscale x 4 x i32> %7)
----------------
Can you duplicate this test, but using ld2 and st2, so that we have at least one test for the structured load/stores?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114506/new/

https://reviews.llvm.org/D114506