[PATCH] D113717: [Symbolizer][Debuginfo] Add debuginfod client to llvm-symbolizer.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 9 02:38:13 PST 2021
jhenderson added inline comments.
================
Comment at: llvm/tools/llvm-symbolizer/llvm-symbolizer.cpp:265-266
InitLLVM X(argc, argv);
+ // The HTTPClient must be initialized for use by the debuginfod client.
+ HTTPClient::initialize();
sys::InitializeCOMRAII COM(sys::COMThreadingMode::MultiThreaded);
----------------
Could we RAII this somehow, so that the explicit cleanup at the end isn't needed? Also, I below the typical user won't be using the debuginfod client, so maybe it should be lazily initialized?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113717/new/
https://reviews.llvm.org/D113717
More information about the llvm-commits
mailing list