[PATCH] D115323: [MetaRenamer] Add command line options to disable renaming specified prefixes

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LG. I don't have any particular familiarity with this pass, but the addition looks reasonable and this is an internal debugging pass anyway. (Also TIL, I've made good use of it already after seeing this patch!)



================
Comment at: llvm/lib/Transforms/Utils/MetaRenamer.cpp:41
+static cl::opt<std::string> RenameExcludeFunctionsPrefixes(
+    "rename-exclude-functions-prefixes",
+    cl::desc("Prefixes for functions that don't need to be renamed, separated "
----------------
I think these options should be called `rename-exclude-function-prefixes` (without the `s` on function etc).


================
Comment at: llvm/test/Transforms/MetaRenamer/exclude-names.ll:1
+; RUN: opt -passes=metarenamer -rename-exclude-functions-prefixes=my_func -rename-exclude-globals-prefixes=my_global -rename-exclude-structs-prefixes=my_struct -rename-exclude-aliases-prefixes=my_alias -S %s | FileCheck %s
+
----------------
I'd suggest adding some symbols that //can// be renamed to this test as well, to check that it's only affecting prefixes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115323/new/

https://reviews.llvm.org/D115323