[PATCH] D115416: [lld-macho] Prevent writing map files on the critical path

[Jez Ng via Phabricator via llvm-commits]

int3 requested changes to this revision.
int3 added a comment.
This revision now requires changes to proceed.

did you forget to add the implementation of `writeMapAsync`?



================
Comment at: lld/MachO/Writer.cpp:1151-1152
   finalizeAddresses();
+  std::future<void> writeMapAsync(std::async(writeMapFile));
   finalizeLinkEditSegment();
   writeOutputFile();
----------------
oontvoo wrote:
> 
yeah, I don't think the map file contains anything from LinkEdit, but just to be safe I would move it after everything's finalized. I'm assuming `writeOutputFile` takes longer than `writeMapAsync` anyway


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115416/new/

https://reviews.llvm.org/D115416