[PATCH] D115409: [SelectionDAGBuilder] drop special handling for CallBr

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/CodeGen/X86/callbr-asm-bb-exports.ll:23
+; CHECK-NEXT: t30: ch,glue = inlineasm_br t22, {{.*}}, t22:1
+; CHECK-NEXT: t32: ch = br t30, BasicBlock:ch
 
----------------
@craig.topper can you triple check this change to this whole file carefully, please?

I'm not sure TBH why my change to SelectionDAGBuilder changed this.  I'm also not sure of the original intent of the test. It's running `-debug-only=isel` which prints A LOT of different phases; I'm not sure which it was originally testing.

I'm not sure why we get an `BlockAddress` now; I don't really understand the output from selectionDAG here. (`t16` looks unused to me, IIUC).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115409/new/

https://reviews.llvm.org/D115409