[PATCH] D115410: [llvm][test] rewrite callbr to use i rather than X constraint NFC
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 8 17:44:07 PST 2021
nickdesaulniers added inline comments.
================
Comment at: llvm/test/Verifier/callbr.ll:41
; the asm goto is in the arg list to the asm).
- callbr void asm sideeffect "${0:l} ${1:l} ${2:l}", "X,X,X"(i8* blockaddress(@test3, %4), i8* blockaddress(@test3, %2), i8* blockaddress(@test3, %3))
+ callbr void asm sideeffect "${0:l} ${1:l} ${2:l}", "i,X,i"(i8* blockaddress(@test3, %4), i8* blockaddress(@test3, %2), i8* blockaddress(@test3, %3))
to label %1 [label %3, label %4]
----------------
Note to reviewers, this is the only case that was interesting IMO, because the middle input operand is not an indirect destination. Ie. the label referred to in the `blockaddress` parameter is not duplicated in the `[]` on the next line.
Not that it makes a difference, just preemptively answering the question: "why is this case different from everything else in this change?"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115410/new/
https://reviews.llvm.org/D115410
More information about the llvm-commits
mailing list