[PATCH] D111276: [ArgumentPromotion] Support opaque pointers

Josh Stone via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 17:42:32 PST 2021


cuviper updated this revision to Diff 393000.
cuviper added a comment.

Make the recursion check the same for typed or opaque pointers

The pointer type is no longer considered at all when checking for
recursive loads in arg promotion, so we have parity with or without
opaque pointers. The new test ArgumentPromotion/opaque-recursion.ll
shows what otherwise could have worked fine with typed pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111276/new/

https://reviews.llvm.org/D111276

Files:
  llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
  llvm/test/Transforms/ArgumentPromotion/aggregate-promote-dead-gep.ll
  llvm/test/Transforms/ArgumentPromotion/aggregate-promote.ll
  llvm/test/Transforms/ArgumentPromotion/attrs.ll
  llvm/test/Transforms/ArgumentPromotion/basictest.ll
  llvm/test/Transforms/ArgumentPromotion/byval-2.ll
  llvm/test/Transforms/ArgumentPromotion/byval.ll
  llvm/test/Transforms/ArgumentPromotion/chained.ll
  llvm/test/Transforms/ArgumentPromotion/control-flow.ll
  llvm/test/Transforms/ArgumentPromotion/control-flow2.ll
  llvm/test/Transforms/ArgumentPromotion/crash.ll
  llvm/test/Transforms/ArgumentPromotion/dbg.ll
  llvm/test/Transforms/ArgumentPromotion/dead-gep-no-promotion.ll
  llvm/test/Transforms/ArgumentPromotion/opaque-recursion.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111276.393000.patch
Type: text/x-patch
Size: 39178 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211209/60f674d9/attachment.bin>


More information about the llvm-commits mailing list