[PATCH] D115302: GlobalsModRef should treat functions w/o nosync conservatively.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 16:30:33 PST 2021


tra added a comment.

In D115302#3181399 <https://reviews.llvm.org/D115302#3181399>, @jdoerfert wrote:

> It seems the function w/o `nosycn` is already treated as potential clobber of the global while the intrinsic is not. This patch now "unifies" it by looking for nosync at the call site, but maybe we should not pretend intrinsics are special. 
> Here is your original example with a function instead of an intrinsic, all seems to work just fine: https://godbolt.org/z/7cn8jKz17

That is a very good point. Let me see if I can figure out what makes intrinsics (even non-existing ones) special.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115302/new/

https://reviews.llvm.org/D115302



More information about the llvm-commits mailing list