[llvm] 7df1855 - Support: Avoid using SmallVector::set_size() in sys::path

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 16:22:51 PST 2021


Author: Duncan P. N. Exon Smith
Date: 2021-12-08T16:22:37-08:00
New Revision: 7df18557791ea1cf8f4f55d97d47ff5008f3bbbb

URL: https://github.com/llvm/llvm-project/commit/7df18557791ea1cf8f4f55d97d47ff5008f3bbbb
DIFF: https://github.com/llvm/llvm-project/commit/7df18557791ea1cf8f4f55d97d47ff5008f3bbbb.diff

LOG: Support: Avoid using SmallVector::set_size() in sys::path

Stop using `SmallVector::set_size()` in sys::path APIs. In both cases,
use `truncate()` instead.

Differential Revision: https://reviews.llvm.org/D115391

Added: 
    

Modified: 
    llvm/lib/Support/Path.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Support/Path.cpp b/llvm/lib/Support/Path.cpp
index 3957547dfaaac..7c99d088911c6 100644
--- a/llvm/lib/Support/Path.cpp
+++ b/llvm/lib/Support/Path.cpp
@@ -474,7 +474,7 @@ StringRef parent_path(StringRef path, Style style) {
 void remove_filename(SmallVectorImpl<char> &path, Style style) {
   size_t end_pos = parent_path_end(StringRef(path.begin(), path.size()), style);
   if (end_pos != StringRef::npos)
-    path.set_size(end_pos);
+    path.truncate(end_pos);
 }
 
 void replace_extension(SmallVectorImpl<char> &path, const Twine &extension,
@@ -486,7 +486,7 @@ void replace_extension(SmallVectorImpl<char> &path, const Twine &extension,
   // Erase existing extension.
   size_t pos = p.find_last_of('.');
   if (pos != StringRef::npos && pos >= filename_pos(p, style))
-    path.set_size(pos);
+    path.truncate(pos);
 
   // Append '.' if needed.
   if (ext.size() > 0 && ext[0] != '.')


        


More information about the llvm-commits mailing list