[llvm] 0383872 - AMDGPU: Simplify test for SGPR spilling bug

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 15:57:37 PST 2021


Author: Matt Arsenault
Date: 2021-12-08T18:40:44-05:00
New Revision: 0383872295bed5f393a174bac827b25c3d24a3cf

URL: https://github.com/llvm/llvm-project/commit/0383872295bed5f393a174bac827b25c3d24a3cf
DIFF: https://github.com/llvm/llvm-project/commit/0383872295bed5f393a174bac827b25c3d24a3cf.diff

LOG: AMDGPU: Simplify test for SGPR spilling bug

Remove the control flow from the test from
25eb7fa01d7ebbe67648ea03841cda55b4239ab2. It's not necessary to
reproduce the original assert with the patch reverted. The control
flow happens to expose a different issue that calls for a separate
test in a future change.

Added: 
    

Modified: 
    llvm/test/CodeGen/AMDGPU/sgpr-spill-incorrect-fi-bookkeeping-bug.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/AMDGPU/sgpr-spill-incorrect-fi-bookkeeping-bug.ll b/llvm/test/CodeGen/AMDGPU/sgpr-spill-incorrect-fi-bookkeeping-bug.ll
index 741c564ddb71..02f90ba22770 100644
--- a/llvm/test/CodeGen/AMDGPU/sgpr-spill-incorrect-fi-bookkeeping-bug.ll
+++ b/llvm/test/CodeGen/AMDGPU/sgpr-spill-incorrect-fi-bookkeeping-bug.ll
@@ -10,7 +10,6 @@ define amdgpu_kernel void @kernel0(i32 addrspace(1)* %out, i32 %in) #1 {
   call void asm sideeffect "", "~{v[16:19]}"() #0
   call void asm sideeffect "", "~{v[20:21]}"() #0
   call void asm sideeffect "", "~{v22}"() #0
-
   %val0 = call <2 x i32> asm sideeffect "; def $0", "=s" () #0
   %val1 = call <4 x i32> asm sideeffect "; def $0", "=s" () #0
   %val2 = call <8 x i32> asm sideeffect "; def $0", "=s" () #0
@@ -31,10 +30,6 @@ define amdgpu_kernel void @kernel0(i32 addrspace(1)* %out, i32 %in) #1 {
   %val17 = call <4 x i32> asm sideeffect "; def $0", "=s" () #0
   %val18 = call <8 x i32> asm sideeffect "; def $0", "=s" () #0
   %val19 = call <16 x i32> asm sideeffect "; def $0", "=s" () #0
-  %cmp = icmp eq i32 %in, 0
-  br i1 %cmp, label %bb0, label %ret
-
-bb0:
   call void asm sideeffect "; use $0", "s"(<2 x i32> %val0) #0
   call void asm sideeffect "; use $0", "s"(<4 x i32> %val1) #0
   call void asm sideeffect "; use $0", "s"(<8 x i32> %val2) #0
@@ -55,9 +50,6 @@ bb0:
   call void asm sideeffect "; use $0", "s"(<4 x i32> %val17) #0
   call void asm sideeffect "; use $0", "s"(<8 x i32> %val18) #0
   call void asm sideeffect "; use $0", "s"(<16 x i32> %val19) #0
-  br label %ret
-
-ret:
   ret void
 }
 


        


More information about the llvm-commits mailing list