[PATCH] D114832: [SROA] Improve SROA to prevent generating redundant coalescing operations.

[Guozhi Wei via Phabricator via llvm-commits]

Carrot added a comment.

> Driven by the compile-time feedback, another thing for me to consider, (probably after a preliminary convergence on the pass to add analysis info or do the transform), is to prune the existing solution so it's faster on the benchmark.

Your current method is

  1 collect all accesses to an alloca object, mark the access type
  2 check the aggregated access types, if there is only <store constant> type, mark the object as unsplittable.

I think in step1, if the access type is not <store constant>, you can bail out early, then for most splittable objects the check can be finished quickly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114832/new/

https://reviews.llvm.org/D114832