[PATCH] D115302: GlobalsModRef should treat functions w/o nosync conservatively.

Wed Dec 8 15:45:15 PST 2021

tra added a comment.

In D115302#3181294 <https://reviews.llvm.org/D115302#3181294>, @jdoerfert wrote:

> But then I'm confused. The code that is patched here is generic for calls, no? I think this is a particular intrinsic issue.

I don't know why `@llvm.sync` and `@sync` are treated differently in your example. I doubt this  patch will change that.

On the other hand,  both `@llvm.sync` and `@sync` are just functions w/o `nosync` (and no other relevant attributes) and that is sufficient to treat them conservatively with this patch in place.

It's quite possible that in your case this patch only masks the issue.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115302/new/

https://reviews.llvm.org/D115302