[PATCH] D115224: [RISCV] Support named opcodes in .insn directive.

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:183
+}
+def uimm7_opcode : Operand<XLenVT> {
+  let ParserMatchClass = InsnDirectiveOpcode;
----------------
Needs a line between these


================
Comment at: llvm/test/MC/RISCV/insn-invalid.s:25
+# Unrecognized opcode name
+.insn r UNKNOWN, 0, a1, a2, a3 #CHECK: :[[@LINE]]:9: error: operand must be a valid opcode name or an integer in the range [0, 127]
----------------
Group these with the other invalid operand tests? i.e. leave the `.insn_i` test as a special case at the end of the file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115224/new/

https://reviews.llvm.org/D115224