[PATCH] D114895: [SelectionDagBuilder] improve CallBrInst BlockAddress constraint handling

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

In D114895#3178108 <https://reviews.llvm.org/D114895#3178108>, @nickdesaulniers wrote:

> As in always convert it to a `TargetBlockAddress` during selectiondagisel?

Not sure if we need to convert it to a TargetBlockAddress specifically?  We just need to make sure we don't copy the value into a register.  I didn't dig too deeply into it, but I think we're doing something weird to specifically make "X" not do the right thing, compared to "i"; see TargetLowering::LowerXConstraint.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114895/new/

https://reviews.llvm.org/D114895