[PATCH] D115302: GlobalsModRef should treat functions w/o nosync conservatively.

[Pete Cooper via Phabricator via llvm-commits]

pete added a subscriber: ahatanak.
pete added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:418-419
                                                         [llvm_ptr_ty]>;
-def int_objc_autoreleasePoolPop             : Intrinsic<[], [llvm_ptr_ty]>;
-def int_objc_autoreleasePoolPush            : Intrinsic<[llvm_ptr_ty], []>;
+def int_objc_autoreleasePoolPop             : Intrinsic<[], [llvm_ptr_ty], [IntrNoSync]>;
+def int_objc_autoreleasePoolPush            : Intrinsic<[llvm_ptr_ty], [], [IntrNoSync]>;
 def int_objc_autoreleaseReturnValue         : Intrinsic<[llvm_ptr_ty],
----------------
tra wrote:
> @pete -- is `IntrNoSync` valid for these intrinsics? 
> 
> If not, then the `test/Analysis/GlobalsModRef/intrinsic_addressnottaken*.ll` need to be changed as they would no longer work if these intrinsics do not have `IntrNoSync`.
I think its valid yeah.  @ahatanak might know for sure, as I think he's looked at this more recently than I have.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115302/new/

https://reviews.llvm.org/D115302