[PATCH] D115394: [instcombine] Do demanded elts last when visiting extractelement

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 8 13:34:10 PST 2021


reames added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/X86/x86-avx512-inseltpoison.ll:1066
 ; CHECK-NEXT:    [[TMP1:%.*]] = extractelement <4 x float> [[A:%.*]], i64 0
-; CHECK-NEXT:    [[TMP2:%.*]] = extractelement <4 x float> [[B:%.*]], i64 0
-; CHECK-NEXT:    [[TMP3:%.*]] = extractelement <4 x float> [[C:%.*]], i64 0
+; CHECK-NEXT:    [[TMP2:%.*]] = extractelement <4 x float> [[B:%.*]], i32 0
+; CHECK-NEXT:    [[TMP3:%.*]] = extractelement <4 x float> [[C:%.*]], i32 0
----------------
The index types here differ because we don't canonicalize either way, and depending on transform order we can get either.  D115387 adds the canonicalization, but I'd prefer not to block this patch on that one.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115394/new/

https://reviews.llvm.org/D115394



More information about the llvm-commits mailing list